perf(trace-explorer): Service Entry spans always have group 0 #72817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Group is only computed for the spans for the various insights modules. Service entry spans always have a group of 0, so leverage that for optimization.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #72817 +/- ##
===========================================
+ Coverage 56.97% 78.05% +21.07%
===========================================
Files 6594 6604 +10
Lines 294123 294092 -31
Branches 50700 50712 +12
===========================================
+ Hits 167575 229549 +61974
+ Misses 121754 58304 -63450
- Partials 4794 6239 +1445
|
wmak
approved these changes
Jun 17, 2024
|
PR reverted: 9ebd80d |
getsentry-bot
added a commit
that referenced
this pull request
Jun 18, 2024
…#72817)" This reverts commit 0d4df7e. Co-authored-by: Zylphrex <[email protected]>
|
Reverting since this assumption seems to be false for http.server transactions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group is only computed for the spans for the various insights modules. Service entry spans always have a group of 0, so leverage that for optimization.