Skip to content

Conversation

@malwilley
Copy link
Member

In certain situations, clicking out of an open CompactSelect would steal focus back to itself.

Before:

CleanShot.2024-06-17.at.12.30.31.mp4

After:

CleanShot.2024-06-17.at.12.30.50.mp4

…o itself after clicking into another element
@malwilley malwilley requested review from a team June 17, 2024 20:05
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 17, 2024
@codecov
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (466af61) to head (44ec943).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #72883      +/-   ##
==========================================
- Coverage   78.05%   78.04%   -0.01%     
==========================================
  Files        6605     6604       -1     
  Lines      294416   294429      +13     
  Branches    50750    50759       +9     
==========================================
- Hits       229795   229794       -1     
- Misses      58286    58300      +14     
  Partials     6335     6335              
Files Coverage Δ
static/app/components/compactSelect/control.tsx 92.24% <100.00%> (+0.12%) ⬆️
static/app/utils/useOverlay.tsx 95.08% <100.00%> (+0.16%) ⬆️

... and 32 files with indirect coverage changes

@malwilley malwilley merged commit e18471d into master Jun 18, 2024
@malwilley malwilley deleted the malwilley/fix/compact-select-trigger-focus branch June 18, 2024 16:04
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants