fix(trace_timeline): Support for trace timeline and related issues (team/free plans) #72933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d issues If we fetch the events endpoint without specifying a project it queries across all projects. Organizations without the `global-views` feature (e.g. free plan) would fail to return any events, thus, the trace timeline would not be displayed. This changes the `useTraceTimelineEvents` to always include the `project` query parameter by either setting it to `-1` (which queries all projects) or to the current project (e.g. the organization is on the free plan). This will enable the trace timeline and related issues for free plans for events/issues within the same project. If a trace contains events for other projects, we will only show the link to the trace but not the trace timeline or related issues.
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 8.87kB ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #72933 +/- ##
=======================================
Coverage 78.04% 78.05%
=======================================
Files 6604 6605 +1
Lines 294370 294432 +62
Branches 50749 50767 +18
=======================================
+ Hits 229747 229814 +67
+ Misses 58294 58288 -6
- Partials 6329 6330 +1
|
armenzg
changed the title
armenzg
commented
Jun 18, 2024
static/app/views/issueDetails/traceTimeline/traceTimeline.spec.tsx
Outdated
Show resolved
Hide resolved
scttcper
approved these changes
Jun 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we fetch the events endpoint without specifying a project it queries across all projects. Organizations without the
global-viewsfeature (e.g. free and team plans) would fail to return any events, thus, the trace timeline would not be displayed.This changes the
useTraceTimelineEventsto always include theprojectquery parameter by either setting it to-1(which queries all projects) or to the current project (e.g. the organization is on the free plan).This will enable the trace timeline and related issues for free plans for events/issues within the same project.
If a trace contains events for other projects, we will only show the link to the trace but not the trace timeline or related issues.