Skip to content

ref: fix types for create_or_update to match the requirements of BaseManager #73596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2024
Merged

ref: fix types for create_or_update to match the requirements of BaseManager #73596

merged 1 commit into from
Jul 1, 2024

Conversation

@asottile-sentry
Copy link
Contributor

@asottile-sentry asottile-sentry commented Jul 1, 2024

fixes this when managers are type checked:

src/sentry/db/models/manager/base.py:481: error: Argument 1 to "create_or_update" has incompatible type "type[M]"; expected "type[BaseModel]"  [arg-type]

@asottile-sentry asottile-sentry requested review from a team July 1, 2024 18:26
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 1, 2024
@asottile-sentry asottile-sentry enabled auto-merge (squash) July 1, 2024 18:27
@asottile-sentry asottile-sentry merged commit 646521b into master Jul 1, 2024
@asottile-sentry asottile-sentry deleted the asottile-typing-create-or-update branch July 1, 2024 18:56
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joshuarli joshuarli joshuarli approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asottile-sentry @joshuarli