ref(proguard): Remove separate queue #74198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #74198 +/- ##
=======================================
Coverage 78.19% 78.19%
=======================================
Files 6659 6659
Lines 297424 297420 -4
Branches 51184 51183 -1
=======================================
- Hits 232584 232582 -2
+ Misses 58525 58523 -2
Partials 6315 6315
|
Swatinem
approved these changes
Jul 15, 2024
Member
Swatinem
left a comment
Swatinem
left a comment
There was a problem hiding this comment.
🎉 next step, kill the deployment, then profit
Contributor
Author
|
Reverting this, the worker first needs to be removed in ops. |
Contributor
|
PR reverted: a1ab12d |
getsentry-bot
added a commit
that referenced
this pull request
Jul 15, 2024
This reverts commit 1b13e98. Co-authored-by: loewenheim <[email protected]>
loewenheim
added a commit
that referenced
this pull request
Jul 15, 2024
Take two of #74198. The worker was removed in getsentry/ops#11403.
priscilawebdev
pushed a commit
that referenced
this pull request
Jul 16, 2024
We stopped routing events to the `process_event_proguard` task (and therefore the `events.process_event_proguard` queue) in #74075. The `store.separate-proguard-queue-rate` option was removed from the options automator in getsentry/sentry-options-automator#1895.
priscilawebdev
pushed a commit
that referenced
this pull request
Jul 16, 2024
This reverts commit 1b13e98. Co-authored-by: loewenheim <[email protected]>
priscilawebdev
pushed a commit
that referenced
this pull request
Jul 16, 2024
Take two of #74198. The worker was removed in getsentry/ops#11403.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We stopped routing events to the
process_event_proguardtask (and therefore theevents.process_event_proguardqueue) in #74075. Thestore.separate-proguard-queue-rateoption was removed from the options automator in https://github.com/getsentry/sentry-options-automator/pull/1895.