Skip to content

Conversation

@jangjodi
Copy link
Contributor

Add killswitches for each feature flag since these are now managed in feature handlers in getsentry
We will check the killswitch in the feature handler so we can turn off the feature faster

@jangjodi jangjodi requested a review from a team July 15, 2024 15:15
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Jul 15, 2024
@jangjodi jangjodi removed the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 15, 2024
@getsentry getsentry deleted a comment from github-actions bot Jul 15, 2024
@codecov
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.11%. Comparing base (43b5124) to head (5fb39bf).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #74274      +/-   ##
==========================================
- Coverage   78.11%   78.11%   -0.01%     
==========================================
  Files        6665     6665              
  Lines      298007   298011       +4     
  Branches    51291    51291              
==========================================
+ Hits       232776   232779       +3     
- Misses      58955    58957       +2     
+ Partials     6276     6275       -1     
Files Coverage Δ
src/sentry/options/defaults.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@jangjodi jangjodi merged commit 9ee245d into master Jul 15, 2024
@jangjodi jangjodi deleted the jodi/similarity-feature-killswitches branch July 15, 2024 16:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants