Skip to content

Conversation

@vartec
Copy link
Contributor

@vartec vartec commented Jul 22, 2024

Adds stricter decorator type checking for leaky bucket

@vartec vartec requested a review from a team as a code owner July 22, 2024 22:00
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 22, 2024
@codecov
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.15%. Comparing base (efd4c84) to head (1655df9).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #74687   +/-   ##
=======================================
  Coverage   78.14%   78.15%           
=======================================
  Files        6728     6728           
  Lines      300002   300012   +10     
  Branches    51616    51618    +2     
=======================================
+ Hits       234441   234465   +24     
+ Misses      59236    59222   -14     
  Partials     6325     6325           
Files Coverage Δ
src/sentry/ratelimits/leaky_bucket.py 98.75% <100.00%> (+0.03%) ⬆️

... and 11 files with indirect coverage changes

Copy link
Contributor

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vartec vartec merged commit 0066487 into master Jul 23, 2024
@vartec vartec deleted the vartec/leaky-bucket-stricter-decorator-typing branch July 23, 2024 17:57
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants