feat(insights): implement geo region selector in web vitals and assets #76185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
KevinL10
approved these changes
Aug 14, 2024
static/app/views/insights/browser/resources/components/resourceView.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| const query = decodeScalar(location.query.query, ''); | ||
| const browserTypes = decodeBrowserTypes(location.query[SpanIndexedField.BROWSER_NAME]); | ||
| const subregions = decodeList( |
There was a problem hiding this comment.
I think it would make sense to use a custom query decoder for all of these places we're decoding the subregions -- similar to decodeBrowserTypes -- so that we can guarantee the regions are valid
There was a problem hiding this comment.
Hmm, When would this occur?
I suppose we can just be safe here, and cover the manual case.
although the query would still succeed. (Would just look for a region that doesn't exist)
There was a problem hiding this comment.
I'm going to address this in another PR, i'm still not 100% sure on the benefit so i'll give it some thought, there are 2 cases I can see that would produce an invalid regions.
- Our code somehow produces an invalid subregion. In this case, i feel as though adding decodeSubregion might actually mask any problem we have in code that shouldn't be occurring anyways. I think we would want to see if this problem occurs.
- The user manually enters a subregion in the url bar. In this case the query should succeed here anyways, unless they enter a string that happens to match some other query syntax. Which in that case i think it might be better to show a failed query in our UI, so that the user knows what they entered in the url bar doesn't make sense. Either way I like the idea of showing the user the results of their own changes in the url bar.
mjq
approved these changes
Aug 14, 2024
static/app/views/insights/browser/resources/utils/useResourceFilters.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work toward #75230
Adds geo selector in the web vitals and resource module and ensure all queries gets the filter applied
NOTE: not all the metrics are properly tagged yet, so web vitals doesn't work entierely yet, and the resource module doesn't have geo data for resource size metrics. Its all behind a feature flag, so this not an issue that customers can see.