Skip to content

Conversation

@scttcper
Copy link
Member

@scttcper scttcper commented Sep 13, 2024

The replay sidequest don't seem to open 100% of the time. the current version attempts to navigate to replays with #replay-sidequest but this sometimes doesn't work since the panel attempts to close at the same time

the area we close the panel on navigation

useEffect(() => void hidePanel(), [location?.pathname]);

the performance-sidequest seems to work better but it also provides a project id? Maybe related to global selection setting a project id on page load

if (projectsForOnboarding.length) {
navigateTo(
`/organizations/${organization.slug}/performance/?project=${projectsForOnboarding[0].id}#performance-sidequest`,
router
);
return;
}
navigateTo(
`/organizations/${organization.slug}/performance/?project=${projectsWithoutFirstTransactionEvent[0].id}#performance-sidequest`,
router
);

the current version attempts to navigate to replays with `#replay-sidequest` but this sometimes doesn't work since the panel attempts to close at the same time

https://github.com/getsentry/sentry/blob/f72a7fc875fcfaf3ce2f28404e4d321ddfbbaff3/static/app/components/sidebar/index.tsx#L160
@scttcper scttcper requested review from a team September 13, 2024 20:23
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 13, 2024
@codecov
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tic/app/components/onboardingWizard/taskConfig.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #77516      +/-   ##
==========================================
- Coverage   78.11%   78.11%   -0.01%     
==========================================
  Files        6957     6957              
  Lines      308809   308823      +14     
  Branches    50539    50542       +3     
==========================================
+ Hits       241231   241233       +2     
- Misses      61188    61200      +12     
  Partials     6390     6390              

@scttcper scttcper enabled auto-merge (squash) September 13, 2024 20:39
@scttcper scttcper merged commit 9149a05 into master Sep 13, 2024
@scttcper scttcper deleted the scttcper/replay-welcome-url branch September 13, 2024 20:45
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants