Skip to content

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Mar 18, 2025

Tooltip with disabled skips rendering and just renders children

@JonasBa JonasBa requested a review from a team as a code owner March 18, 2025 14:58
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 18, 2025
// Reset the visibility when the tooltip becomes disabled
useEffect(() => {
if (disabled) {
if (disabled && isOpen) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was wrong, and was causing the callback to be unnecessarily executed.

@JonasBa JonasBa changed the title button: remove the extra wrap button: remove extra button wrap Mar 18, 2025
Base automatically changed from jb/button/chonkify to master March 19, 2025 18:32
@codecov
Copy link

codecov bot commented Mar 19, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
9969 1 9968 4
View the top 1 failed test(s) by shortest run time
Dashboards > Detail prebuilt dashboards assigns unique IDs to all widgets so grid keys are unique
Stack Traces | 1.4s run time
Error: Unable to find an element with the text: Default Widget 1. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../views/dashboards/detail.spec.tsx:191:48)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@JonasBa JonasBa merged commit a63a847 into master Mar 20, 2025
40 checks passed
@JonasBa JonasBa deleted the jb/button/remove-wrap branch March 20, 2025 11:44
andrewshie-sentry pushed a commit that referenced this pull request Mar 27, 2025
Tooltip with disabled skips rendering and just renders children
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants