Skip to content

Conversation

@edwardgou-sentry
Copy link
Contributor

Adds an All Queries page containing a table view of owned and shared saved explore queries. Guarded behind the performance-saved-queries feature flag, and accessible from the sidenav under Explore.

Many features on this page are still in progress.

image

@edwardgou-sentry edwardgou-sentry requested a review from a team March 19, 2025 20:37
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review March 19, 2025 20:37
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner March 19, 2025 20:37
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 19, 2025
@codecov
Copy link

codecov bot commented Mar 20, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
9984 2 9982 12
View the top 2 failed test(s) by shortest run time
SavedQueriesTable should request for shared queries
Stack Traces | 1.02s run time
Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

Expected: ".../org-slug/explore/saved/", ObjectContaining {"data": ObjectContaining {"exclude": "owned", "sortBy": "mostPopular"}, "method": "GET"}
Received: ".../org-slug/explore/saved/", {"data": undefined, "error": [Function error], "headers": undefined, "host": undefined, "method": "GET", "query": {"exclude": "owned", "per_page": 5, "sortBy": "mostPopular"}, "success": [Function success]}

Number of calls: 1

Ignored nodes: comments, script, style
...
    at .../explore/savedQueries/savedQueriesTable.spec.tsx:62:74
    at runWithExpensiveErrorDiagnosticsDisabled (.../sentry/sentry/node_modules/@.../dom/dist/config.js:47:12)
    at checkCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:124:77)
    at checkRealTimersCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:118:16)
    at Timeout.task [as _onTimeout] (.../sentry/sentry/node_modules/jsdom/lib/jsdom/browser/Window.js:520:19)
    at listOnTimeout (node:internal/timers:594:17)
    at processTimers (node:internal/timers:529:7)
SavedQueriesTable should request for owned queries
Stack Traces | 1.04s run time
Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

Expected: ".../org-slug/explore/saved/", ObjectContaining {"data": ObjectContaining {"exclude": "shared", "sortBy": "mostPopular"}, "method": "GET"}
Received: ".../org-slug/explore/saved/", {"data": undefined, "error": [Function error], "headers": undefined, "host": undefined, "method": "GET", "query": {"exclude": "shared", "per_page": 5, "sortBy": "mostPopular"}, "success": [Function success]}

Number of calls: 1

Ignored nodes: comments, script, style
...
    at .../explore/savedQueries/savedQueriesTable.spec.tsx:50:74
    at runWithExpensiveErrorDiagnosticsDisabled (.../sentry/sentry/node_modules/@.../dom/dist/config.js:47:12)
    at checkCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:124:77)
    at checkRealTimersCallback (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:118:16)
    at Timeout.task [as _onTimeout] (.../sentry/sentry/node_modules/jsdom/lib/jsdom/browser/Window.js:520:19)
    at listOnTimeout (node:internal/timers:594:17)
    at processTimers (node:internal/timers:529:7)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

@DominikB2014 DominikB2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@edwardgou-sentry edwardgou-sentry merged commit fa5230e into master Mar 21, 2025
40 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/saved-queries-view branch March 21, 2025 15:05
@sentry
Copy link

sentry bot commented Mar 26, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TestingLibraryElementError: Unable to find an element with the text: Query Name. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible. Object.?(savedQueriesTable.spec.tsx) View Issue
  • ‼️ TestingLibraryElementError: Unable to find an element with the text: Query Name. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible. Object.?(savedQueriesTable.spec.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

andrewshie-sentry pushed a commit that referenced this pull request Mar 27, 2025
Adds an `All Queries` page containing a table view of owned and shared
saved explore queries. Guarded behind the `performance-saved-queries`
feature flag, and accessible from the sidenav under `Explore`.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants