Skip to content

Conversation

@Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Apr 14, 2025

This adds support for the count_unique aggregate in eap enabled views.

Closes EXP-7

This adds support for the `count_unique` aggregate in eap enabled views.
@Zylphrex Zylphrex requested a review from a team April 14, 2025 22:16
@Zylphrex Zylphrex requested review from a team as code owners April 14, 2025 22:16
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 14, 2025
@codecov
Copy link

codecov bot commented Apr 14, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10236 1 10235 5
View the top 1 failed test(s) by shortest run time
WidgetBuilder spans dataset timeseries returns group by and aggregate as primary options
Stack Traces | 1.47s run time
Error: expect(received).toHaveLength(expected)

Expected length: 12
Received length: 13
Received array:  [<p class="e1b0h4f90 css-17bnw9v-Label-overflowEllipsis-withChonk e6ii5yr2" data-test-id="menu-list-item-label" id="«r7ko»">count(…)</p>, <p class="e1b0h4f90 css-17bnw9v-Label-overflowEllipsis-withChonk e6ii5yr2" data-test-id="menu-list-item-label" id="«r7kr»">count_unique(…)</p>, <p class="e1b0h4f90 css-17bnw9v-Label-overflowEllipsis-withChonk e6ii5yr2" data-test-id="menu-list-item-label" id="«r7ku»">avg(…)</p>, <p class="e1b0h4f90 css-17bnw9v-Label-overflowEllipsis-withChonk e6ii5yr2" data-test-id="menu-list-item-label" id="«r7l1»">p50(…)</p>, <p class="e1b0h4f90 css-17bnw9v-Label-overflowEllipsis-withChonk e6ii5yr2" data-test-id="menu-list-item-label" id="«r7l4»">p75(…)</p>, <p class="e1b0h4f90 css-17bnw9v-Label-overflowEllipsis-withChonk e6ii5yr2" data-test-id="menu-list-item-label" id="«r7l7»">p90(…)</p>, <p class="e1b0h4f90 css-17bnw9v-Label-overflowEllipsis-withChonk e6ii5yr2" data-test-id="menu-list-item-label" id="«r7la»">p95(…)</p>, <p class="e1b0h4f90 css-17bnw9v-Label-overflowEllipsis-withChonk e6ii5yr2" data-test-id="menu-list-item-label" id="«r7ld»">p99(…)</p>, <p class="e1b0h4f90 css-17bnw9v-Label-overflowEllipsis-withChonk e6ii5yr2" data-test-id="menu-list-item-label" id="«r7lg»">p100(…)</p>, <p class="e1b0h4f90 css-17bnw9v-Label-overflowEllipsis-withChonk e6ii5yr2" data-test-id="menu-list-item-label" id="«r7lj»">sum(…)</p>, …]
    at Object.<anonymous> (.../dashboards/widgetBuilder/widgetBuilderSortBy.spec.tsx:833:84)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really small comments, but tested it out locally and looks good to me

@Zylphrex Zylphrex merged commit 290e7c9 into master Apr 15, 2025
41 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/add-support-for-count-unique-in-eap branch April 15, 2025 14:55
@sentry
Copy link

sentry bot commented Apr 16, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TestingLibraryElementError: Unable to find an accessible element with the role "button" and name "count" Object.?(content.spec.tsx) View Issue
  • ‼️ Error: �[2mexpect(�[22m�[31mreceived�[39m�[2m).�[22mtoEqual�[2m(�[22m�[32mexpected�[39m�[2m) // deep equality�[22m Object.?(content.spec.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

andrewshie-sentry pushed a commit that referenced this pull request Apr 22, 2025
This adds support for the `count_unique` aggregate in eap enabled views.

Closes EXP-7
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants