-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(ourlogs): Strip ANSI escape codes #89619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import {stripAnsi} from 'sentry/utils/ansiEscapeCodes'; | ||
|
|
||
| describe('ansiEscapeCodes', () => { | ||
| it('removes ANSI color codes', () => { | ||
| const colored = '\x1b[31mThis is red text\x1b[0m'; | ||
| expect(stripAnsi(colored)).toBe('This is red text'); | ||
| }); | ||
|
|
||
| it('removes multiple ANSI codes', () => { | ||
| const input = '\x1b[32mGreen\x1b[0m and \x1b[34mBlue\x1b[0m'; | ||
| expect(stripAnsi(input)).toBe('Green and Blue'); | ||
| }); | ||
|
|
||
| it('returns the original string if there are no ANSI codes', () => { | ||
| const plain = 'Just a normal string.'; | ||
| expect(stripAnsi(plain)).toBe(plain); | ||
| }); | ||
|
|
||
| it('handles empty strings', () => { | ||
| expect(stripAnsi('')).toBe(''); | ||
| }); | ||
|
|
||
| it('handles strings with mixed characters and ANSI codes', () => { | ||
| const input = 'Hello \x1b[1mWorld\x1b[0m!'; | ||
| expect(stripAnsi(input)).toBe('Hello World!'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| /** | ||
| * Strips ANSI escape codes from a string | ||
| * @param input - The string potentially containing ANSI codes | ||
| * @returns The cleaned string without ANSI codes | ||
| */ | ||
| export function stripAnsi(input: string): string { | ||
| // eslint-disable-next-line no-control-regex | ||
| const ansiRegex = /\x1B(?:[@-Z\\-_]|\[[0-?]*[ -/]*[@-~])/g; | ||
| return input.replace(ansiRegex, ''); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.