Skip to content

🔧 chore(integrations): use IntegrationProviderSlug for Integration key #91465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2025
Merged

🔧 chore(integrations): use IntegrationProviderSlug for Integration key #91465

merged 2 commits into from
May 21, 2025

Conversation

@iamrajjoshi
Copy link
Collaborator

@iamrajjoshi iamrajjoshi commented May 12, 2025

standardizing the keys of Integration so we can use the StrEnum for future mappings

@iamrajjoshi iamrajjoshi requested a review from kcons May 12, 2025 18:55
@iamrajjoshi iamrajjoshi self-assigned this May 12, 2025
@iamrajjoshi iamrajjoshi marked this pull request as ready for review May 12, 2025 18:55
@iamrajjoshi iamrajjoshi requested review from a team as code owners May 12, 2025 18:55
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 12, 2025
@codecov
Copy link

codecov bot commented May 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:157341 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #91465       +/-   ##
===========================================
+ Coverage   32.75%   87.63%   +54.88%     
===========================================
  Files        8731    10349     +1618     
  Lines      487593   587749   +100156     
  Branches    22653    22653               
===========================================
+ Hits       159730   515103   +355373     
+ Misses     327444    72227   -255217     
  Partials      419      419

@iamrajjoshi iamrajjoshi merged commit 38e36ef into master May 21, 2025
59 of 60 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/use-integrationproviderslug branch May 21, 2025 15:18
andrewshie-sentry pushed a commit that referenced this pull request Jun 2, 2025
@iamrajjoshi @andrewshie-sentry
🔧 chore(integrations): use IntegrationProviderSlug for Integration …
e631340 
…`key` (#91465)
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@GabeVillalobos GabeVillalobos GabeVillalobos approved these changes

@kcons kcons kcons approved these changes

Assignees

@iamrajjoshi iamrajjoshi

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iamrajjoshi @GabeVillalobos @kcons