ref(reserved budgets): Update types + constants #91606
Conversation
github-actions
bot
added
the
Scope: Frontend
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
the diff looks larger than the actual changes i made (linting made it look like i changed a whole chunk when it was really just indented)
| 'seer_autofix', | ||
| 'seer_scanner', | ||
| ].includes(category) | ||
| ['profile_duration', 'replays', 'spans', 'profile_duration_ui'].includes(category) |
There was a problem hiding this comment.
will make sure to update product trial prompts in product trial frontend pr that will make use of availableReservedBudgetTypes and canProductTrial
| */ | ||
| totalReservedSpend: number; | ||
| }; | ||
| } & ReservedBudgetCategory; |
There was a problem hiding this comment.
| // @ts-expect-error TS(7053): Element implicitly has an 'any' type because expre... Remove this comment to see the full error message | ||
| formData.reserved[category] > 0 && ( | ||
| {activePlan.categories | ||
| .filter(category => activePlan.planCategories[category]) |
There was a problem hiding this comment.
we will render overview info for reserved budgets in checkout separately
| seerAutofix: {singular: 'issue fix', plural: 'issue fixes'}, | ||
| seerScanner: {singular: 'issue scan', plural: 'issue scans'}, |
There was a problem hiding this comment.
whoops i think the names should actually be "issue fix run" and "issue scan run". or we could change that in the backend. We can revisit in a future PR. I don't think the names are super finalized
Dependent on:
This information will be used for things such as product trial management, subscription usage cards, and other frontend rendering.