feat(dashboards): Newly added widgets should scroll into view #91721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: IDs should be stable or else this causes a bunch of unnecessary scrolling
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #91721 +/- ##
==========================================
- Coverage 82.69% 82.69% -0.01%
==========================================
Files 10335 10335
Lines 586485 586483 -2
Branches 22546 22546
==========================================
- Hits 484988 484986 -2
Misses 101051 101051
Partials 446 446 |
narsaynorath
deleted the
narsaynorath/dain-353-dashboards-should-scroll-newly-added-widgets-into-view
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores the newly added widget in the dashboard state, passes it along, and in the sortable component when it renders and sees that it matches the newly added widget, it'll use a ref to scroll itself into view.