trace: fix buttons in chonk #91878
Merged
trace: fix buttons in chonk #91878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
TkDodo
reviewed
May 20, 2025
| data-test-id="trace-drawer-tab-pin-button" | ||
| onClick={props.onClick} | ||
| > | ||
| <PinButton data-test-id="trace-drawer-tab-pin-button" onClick={props.onClick}> |
There was a problem hiding this comment.
Isn’t this more like a Button with priority="transparent" where the StyledIconPin is passed to the icon slot ?
- we’re also missing a
labelhere - the Button would enforce that - the
data-test-idis also a bit of a red flag, as buttons are interactive (likely goes together with the missing label)
There was a problem hiding this comment.
The one issue we have with transparent variant is that it is only supported in chonk, which means we need to @ts-expect-error until the legacy buttons are removed. I've first avoided that, but I think it makes sense. The violations will surface once the old button is removed.
I am also tempted to backport transparent variant to the current buttons set, as it seems like it could be useful here too (note that I've had to remove box shadow and border from the button)
Agree about the label, and I've moved the icon to use the icon slot.
TkDodo
approved these changes
May 21, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
Fixes chonk buttons in trace view Before  After  Fixes DE-49
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes chonk buttons in trace view
Before
After
Fixes DE-49