Skip to content

fix(crons): Floor seconds / microsecond on recorded dateClock #91890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

fix(crons): Floor seconds / microsecond on recorded dateClock #91890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/monitors/consumers/monitor_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,7 @@ def _process_checkin(item: CheckinItem, txn: Transaction | Span) -> None:
#
# XXX: They are NOT timezone aware date times, set the timezone
# to UTC
clock_time = item.ts.replace(tzinfo=UTC)
clock_time = item.ts.replace(second=0, microsecond=0, tzinfo=UTC)

# Record the reported in_progress time when the check is in progress
date_in_progress = start_time if status == CheckInStatus.IN_PROGRESS else None
Expand Down
2 changes: 1 addition & 1 deletion tests/sentry/monitors/consumers/test_monitor_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ def test_check_in_date_clock(self):
self.send_checkin(monitor.slug, ts=ts, item_ts=item_ts)
checkin = MonitorCheckIn.objects.get(guid=self.guid)
assert checkin.date_added == ts.replace(tzinfo=UTC)
assert checkin.date_clock == item_ts.replace(tzinfo=UTC)
assert checkin.date_clock == item_ts.replace(second=0, microsecond=0, tzinfo=UTC)

def test_check_in_date_in_progress(self):
monitor = self._create_monitor(slug="my-monitor")
Expand Down
Loading