feat(replay): Start bringing in new replay context wrappers to test #91982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
billyvg
reviewed
May 20, 2025
| return ( | ||
| <PlayerContainer data-test-id="player-container"> | ||
| {replay?.hasProcessingErrors() ? ( | ||
| <ReplayProcessingError processingErrors={replay.processingErrors()} /> |
There was a problem hiding this comment.
oh, good call out. i meant to comment
It's inside the <ReplayLoaderState> which is already in this file.
The last place that still needs a LoaderState added is the main replay details page; so that's not in this PR yet
billyvg
approved these changes
May 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #91982 +/- ##
==========================================
- Coverage 86.50% 83.94% -2.56%
==========================================
Files 10355 10355
Lines 587384 587382 -2
Branches 22586 22586
==========================================
- Hits 508106 493098 -15008
- Misses 78851 93857 +15006
Partials 427 427 |
antonpirker
pushed a commit
that referenced
this pull request
May 21, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original replay context is a big ball of logic and hacks. It's hard to use and mixes a lot of responsibilities.
A while ago I wrote some smaller context providers to break things up, and remove some old hacks that are no longer needed now, either because rrweb improvements, and because some of the problems were self-inflicted (like some perf hacks, and just doing things the wrong way around).
So this is the first PR to wrap players with the new providers, and to swap out a couple places that use the old context, for calls into the new context. What's apparent already within this PR is that the new context will push
current timere-renders down the react tree. I need to followup and edit a bunch more places before this will be functional, but in the mean time the providers will be a no-op because the new feature-flag is guarding the interaction points.