fix(apps): disallow Manager to rotate an app secret with org:admin scope #92019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #92019 +/- ##
==========================================
+ Coverage 83.79% 87.63% +3.84%
==========================================
Files 10361 10361
Lines 587526 587540 +14
Branches 22594 22594
==========================================
+ Hits 492299 514880 +22581
+ Misses 94806 72239 -22567
Partials 421 421 |
geoffg-sentry
approved these changes
May 21, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://getsentry.atlassian.net/browse/VULN-728