feat(sentryapps): Display sentry apps token usage as app rather than proxy user #93763
Conversation
github-actions
bot
added
the
Scope: Frontend
leeandher
force-pushed
the
leander/eco-625-ui
branch
from
3f79920 to
2f6ac1b
Compare
| componentFunction?: (props: { | ||
| data: GroupActivity['data']; | ||
| sentry_app: GroupActivity['sentry_app']; | ||
| user: GroupActivity['user']; |
There was a problem hiding this comment.
😵 is the stuff in the brackets ({}) creating the dictionary? Or is this like the typing? e.g data: GroupActivity['data'] == data is type GroupActivity['data'] or data is GroupActivity['data'].
if it's the former, is it possible to get more defined/concrete types?
There was a problem hiding this comment.
Everything in the brackets is a type, and it's just referencing the data/sentry_app/user attributes of the GroupActivity type.
With this change I'm just swapping from positional arguments to a single object. It's self documenting (because of the key) and makes it easier to add new props (like sentry_app) without needing to keep track of positional arguments or pass in undefined (e.g. func(data, null, sentryApp) Generally we prefer objects to positional arguments unless theres a good reason for them
| if (sentry_app) { | ||
| return function () { | ||
| return <SentryAppAvatar sentryApp={sentry_app} />; | ||
| }; |
There was a problem hiding this comment.
I think it would be more readable with an arrow func 🤔
| if (sentry_app) { | |
| return function () { | |
| return <SentryAppAvatar sentryApp={sentry_app} />; | |
| }; | |
| if (sentry_app) { | |
| return () => <SentryAppAvatar sentryApp={sentry_app} />; | |
| }; |
There was a problem hiding this comment.
I had it as an arrow function, but the change was automatically performed by eslint, so I don't really have a choice unfortunately :/
There was a problem hiding this comment.
bruh @eslint, there's literally another anon arrow 2 lines later 💀
leeandher
force-pushed
the
leander/eco-625-ui
branch
from
4bde3ed to
f8f6fdb
Compare
haven't encountered this one before but getsentry-bot applying pre-commit fixes was breaking the PR, had to tweak things manually -- should be good in CI now. |
| if (sentry_app) { | ||
| return function () { | ||
| return <SentryAppAvatar sentryApp={sentry_app} />; | ||
| }; |
There was a problem hiding this comment.
bruh @eslint, there's literally another anon arrow 2 lines later 💀
…proxy user (#93763) Before: <img width="980" alt="image" src="https://github.com/user-attachments/assets/257ca029-7eb5-450b-935b-b451c63cfefa" /> After: <img width="905" alt="image" src="https://github.com/user-attachments/assets/441a792f-2678-4c2c-8236-a1b19d86c01c" /> --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Before:
After: