fix(ui): restore height for pageFilterBar #93800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
JonasBa
reviewed
Jun 18, 2025
| display: flex; | ||
| position: relative; | ||
| height: ${p.theme.form.md.height}; |
There was a problem hiding this comment.
They shouldn't ever get as large as in the initial screenshot, so I wonder if there might be some custom CSS rule that could be removed? In theory, if that is fixed, I would expect the size to drop down to the size of the rest of the buttons in that row, and so this height might not even be needed
There was a problem hiding this comment.
I didn’t find anything :/
JonasBa
approved these changes
Jun 18, 2025
TkDodo
deleted the
tkdodo/fix/de-153-fat-button-issue-in-mobile-vitals-screen-summary
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #93800 +/- ##
==========================================
- Coverage 88.02% 84.32% -3.70%
==========================================
Files 10332 10332
Lines 596373 596373
Branches 23163 23163
==========================================
- Hits 524968 502919 -22049
- Misses 70949 92998 +22049
Partials 456 456 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
| before | after | |--------|--------| |  |  | @JonasBa we used to have the `height` explicitly set - like it’s also done in the old theme - but it was removed here: https://github.com/getsentry/sentry/pull/90243/files#diff-32f8334cfccf64122985ca68a14eb551d05ece05ea1e4f3390974d3765195a03L170 do you remember why it was removed, and is it safe to bring it back like this?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JonasBa we used to have the
heightexplicitly set - like it’s also done in the old theme - but it was removed here:https://github.com/getsentry/sentry/pull/90243/files#diff-32f8334cfccf64122985ca68a14eb551d05ece05ea1e4f3390974d3765195a03L170
do you remember why it was removed, and is it safe to bring it back like this?