-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
chore(feedback) remove Feedback model
#99380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #99380 +/- ##
==========================================
+ Coverage 80.68% 81.19% +0.51%
==========================================
Files 8594 8591 -3
Lines 380293 380150 -143
Branches 24144 24115 -29
==========================================
+ Hits 306824 308662 +1838
+ Misses 73115 71135 -1980
+ Partials 354 353 -1 |
fd5c839 to
fb1217f
Compare
environment FK fieldFeedback model
fb1217f to
5a9da0f
Compare
|
This PR has a migration; here is the generated SQL for for --
-- Alter field environment on feedback
--
SET CONSTRAINTS "feedback_feedback_environment_id_fab8783f_fk_sentry_en" IMMEDIATE; ALTER TABLE "feedback_feedback" DROP CONSTRAINT "feedback_feedback_environment_id_fab8783f_fk_sentry_en";
--
-- Moved model feedback to pending deletion state
--
-- (no-op)for --
-- Delete model feedback
--
DROP TABLE "feedback_feedback" CASCADE; |
wedamija
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - please don't merge this until the previous pr has fully deployed
|
sounds good. |
|
This PR has a migration; here is the generated SQL for for --
-- Delete model feedback
--
DROP TABLE "feedback_feedback" CASCADE; |
aliu39
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is Stage 2 for removing the
FeedbackModel.Follow-up to #99379 that removes the
environmentFK field as per our Develop Migration Docs