Skip to content

feat: add explore equation to dashboards #99404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 15, 2025
Merged

feat: add explore equation to dashboards #99404

merged 7 commits into from
Sep 15, 2025

Conversation

@shruthilayaj
Copy link
Member

@shruthilayaj shruthilayaj commented Sep 12, 2025 •
edited
Loading

Adds explore equations to the spans dataset. Note that the spans backend API
does not support the equation index alias format (ie equation[0]) in the sorts.
So we are converting it into the function format before we make the table or stats
request.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 12, 2025
@codecov
Copy link

codecov bot commented Sep 12, 2025

⚠️ File not in storage

No result to display due to the CLI not being able to find the file.
Please ensure the file contains junit in the name and automated file search is enabled,
or the desired file specified by the file and search_dir arguments of the CLI.

@shruthilayaj shruthilayaj marked this pull request as ready for review September 15, 2025 14:57
@shruthilayaj shruthilayaj requested a review from a team September 15, 2025 14:57
cursor[bot]

This comment was marked as outdated.

Sign in to view

nikkikapadia
nikkikapadia reviewed Sep 15, 2025
View reviewed changes
Copy link
Member

@nikkikapadia nikkikapadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me, just one comment about flagging

static/app/views/dashboards/datasetConfig/spans.tsx
defaultField: DEFAULT_FIELD,
defaultWidgetQuery: DEFAULT_WIDGET_QUERY,
enableEquations: false,
enableEquations: true,
Copy link
Member

@nikkikapadia nikkikapadia Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we be conditionally allowing it based on feature flag? i know we have the visibility-explore-equations flag which doesn't seem to be fully rolled out yet 🤔

Copy link
Member Author

@shruthilayaj shruthilayaj Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The add equation button is flagged https://github.com/getsentry/sentry/pull/99404/files#diff-0559dfcce1f9b988a4626e5d7c6624642aa77322acee5f3e4e593614d5e96b57R869-R871, I think that should be good enough?

Copy link
Member

@nikkikapadia nikkikapadia Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh whoopsies i missed that, yup should be good 👍

@shruthilayaj shruthilayaj merged commit d1f112d into master Sep 15, 2025
45 checks passed
@shruthilayaj shruthilayaj deleted the shruthi/feat/add-explore-equation-to-dashboards branch September 15, 2025 15:48
@untitaker untitaker mentioned this pull request Sep 16, 2025
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@nikkikapadia nikkikapadia nikkikapadia approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shruthilayaj @nikkikapadia