ref(feedback): simplify categories test coverage to be more efficient #99451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #99451 +/- ##
==========================================
- Coverage 81.32% 81.21% -0.11%
==========================================
Files 8590 8584 -6
Lines 382261 380141 -2120
Branches 24106 24106
==========================================
- Hits 310864 308735 -2129
- Misses 71051 71060 +9
Partials 346 346 |
github-actions
bot
added
the
Scope: Backend
cmanallen
approved these changes
Sep 15, 2025
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite tests to not do excessive setup (currently saving 15+ feedbacks for every test). 5x speedup locally, from 71s -> 13.8s.
Does the same for
test_feedback_query(renamed tolabel_query). Speedup is negligible here, like 13->9s, but it's still good to update the conventionRelates to REPLAY-698: Improve backend test suite runtime