Skip to content
This repository was archived by the owner on Jun 18, 2021. It is now read-only.

Implement TEXTURE_BINDING_ARRAY extension #360

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Implement TEXTURE_BINDING_ARRAY extension #360

merged 1 commit into from
Jun 11, 2020

Conversation

@cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Jun 11, 2020 •
edited
Loading

This extends gfx-rs/wgpu#711 into wgpu-rs.

Notable changes:

  • Added an example showing off both this extension and the future descriptor indexing extension.
  • Changed the framework so there is a static function showing what extensions you need. This is provided by the trait,, which defaults to no extensions, so existing examples and new ones don't have to care about extensions.

@cwfitzgerald cwfitzgerald requested a review from kvark June 11, 2020 00:19
@cwfitzgerald cwfitzgerald force-pushed the descriptor-arrays branch 3 times, most recently from 6e6348d to 4eb65b3 Compare June 11, 2020 03:43
kvark
kvark suggested changes Jun 11, 2020
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here! I've got a few notes that need to be addressed, but very happy overall :) 👍

@cwfitzgerald
Copy link
Member Author

Should be good from here :)

kvark
kvark approved these changes Jun 11, 2020
View reviewed changes
examples/texture-arrays/main.rs Outdated

fn create_texture_data(color: Color) -> Vec<u8> {
match color {
Color::RED => vec![255, 0, 0, 255],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could just return the fixed-size [u8; 4] without a Vec

@cwfitzgerald
Copy link
Member Author

Picked!
bors r=kvark

@bors
Copy link
Contributor

bors bot commented Jun 11, 2020

Build succeeded:

@bors bors bot merged commit 7b887f1 into gfx-rs:master Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kvark kvark kvark approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cwfitzgerald @kvark