-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add support for bgra8unorm-storage #4228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Currently blocked on gfx-rs/naga#2550 |
teoxoy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few remaining things.
teoxoy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Co-authored-by: Teodor Tanasoaia <[email protected]>
Co-authored-by: Teodor Tanasoaia <[email protected]>
Co-authored-by: Teodor Tanasoaia <[email protected]>
Co-authored-by: Teodor Tanasoaia <[email protected]>
Co-authored-by: Teodor Tanasoaia <[email protected]>
|
@nical the feature is missing from Line 5166 in 6c8ccde was brought up by @crowlKats in #3634 (comment) |
|
I thought changes to deno require approval from @gfx-rs/deno but it seems my review is enough to land this. I remember this wasn't the case previously to adding the wgpu team to the codeowners file (#4162). |
|
good catch, apologies for not having reviewed this. |
|
Alright, this should be ready to land (note: I disabled the feature with vulkan on mac, because of the odd side effect causing the occlusion_query test to fail, I can't spend the time investigating that in the foreseeable future). |
|
I reran the mac job that was failing https://github.com/gfx-rs/wgpu/actions/runs/6496021322/job/17672724374 and it ran successfully. I think it was just flakey (#4235 (comment)). |
|
Ok let's try one last time |
|
Ok it passed, let's merge. |
@teoxoy wgpu has never required any reviews at all to land things, just CI passing - this is a policy I've kept to allow good-faith quick fixes without needing the delay of getting other people involved. |
Checklist
cargo clippy.Connections
This is a continuation of the work that started in #3634
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1829895
Description
Resolves #3359
Testing
There is a basic test in here.
The CTS also has some coverage for this although firefox hasn't updated to a version of the CTS that contains the test (but will soon).