-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[hal/metal] Mesh Shaders #8139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hal/metal] Mesh Shaders #8139
Conversation
Yeah no big problems I can see, all the tests pass and the CTS passes, so outside of concerns with the code, I'm happy to land. |
|
Unfortunately it seems the CI doesn't support mesh shaders, since I think it only supports Metal2. So we won't get that advantage. Related, I believe I've uncovered a logical error in feature detection for int64 and scoped simd, will report |
|
Laaame, alright |
|
@cwfitzgerald I didn't probably address all your comments correctly but can you take a look at what I said |
f70a35c to
7219f95
Compare
cwfitzgerald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, some more cleanup comments, then we should be good.
|
Tests pass, cts passes, lets do this. |
Connections
Related #7197
Similar to #8110
Description
Adds mesh shaders to metal backend
Testing
None yet
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.