Skip to content

Conversation

@inner-daemons
Copy link
Collaborator

@inner-daemons inner-daemons commented Aug 24, 2025

Connections
Related #7197
Similar to #8110

Description
Adds mesh shaders to metal backend

Testing
None yet

Squash or Rebase?

Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@inner-daemons inner-daemons marked this pull request as ready for review August 24, 2025 06:09
@inner-daemons inner-daemons requested a review from a team as a code owner August 24, 2025 06:09
@inner-daemons inner-daemons marked this pull request as draft August 24, 2025 06:39
@inner-daemons inner-daemons mentioned this pull request Aug 24, 2025
36 tasks
@inner-daemons inner-daemons mentioned this pull request Sep 15, 2025
8 tasks
@inner-daemons inner-daemons marked this pull request as ready for review October 11, 2025 06:19
@cwfitzgerald
Copy link
Member

Just to manage expectations, assuming I can get your current comments addressed, should I expect this to be merged soon?

Yeah no big problems I can see, all the tests pass and the CTS passes, so outside of concerns with the code, I'm happy to land.

@inner-daemons
Copy link
Collaborator Author

Unfortunately it seems the CI doesn't support mesh shaders, since I think it only supports Metal2. So we won't get that advantage.

Related, I believe I've uncovered a logical error in feature detection for int64 and scoped simd, will report

@cwfitzgerald
Copy link
Member

Laaame, alright

@inner-daemons
Copy link
Collaborator Author

@cwfitzgerald I didn't probably address all your comments correctly but can you take a look at what I said

@inner-daemons inner-daemons mentioned this pull request Nov 7, 2025
6 tasks
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, some more cleanup comments, then we should be good.

@cwfitzgerald
Copy link
Member

Tests pass, cts passes, lets do this.

@cwfitzgerald cwfitzgerald merged commit d0cf78c into gfx-rs:trunk Nov 15, 2025
42 checks passed
@inner-daemons inner-daemons deleted the mesh-shading/metal branch November 15, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants