Skip to content

Conversation

andyleiserson
Copy link
Contributor

In the encode-on-finish changes, I had put all of the logic related to finishing encoding in Global::command_encoder_finish. Since non-ID-using clients want to bypass Global and call methods on the underlying objects directly, this moves all of the real logic into CommandEncoder::finish and leaves just object retrieval from an ID in Global.

Testing
n/a

Squash or Rebase? Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@teoxoy teoxoy merged commit 3958790 into gfx-rs:trunk Oct 9, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants