Make multi-planar textures renderable #8307
Conversation
noituri
force-pushed
the
@noituri/renderable-nv12-texture
branch
2 times, most recently
from
658925c to
5a10d31
Compare
| if desc.format.is_multi_planar_format() { | ||
| raw_flags |= vk::ImageCreateFlags::MUTABLE_FORMAT; | ||
| raw_flags |= | ||
| vk::ImageCreateFlags::MUTABLE_FORMAT | vk::ImageCreateFlags::EXTENDED_USAGE; | ||
| } |
There was a problem hiding this comment.
Nit regarding extended usage, do we already ensure that we have vulkan 1.1 before we allow multi-planar textures? If not we should add that check.
There was a problem hiding this comment.
If I'm reading the code correctly, TEXTURE_FORMAT_NV12 and TEXTURE_FORMAT_P010 features require VK_KHR_sampler_ycbcr_conversion extension which depends on:
- Vulkan 1.1, OR
VK_KHR_maintenance1andVK_KHR_bind_memory2andVK_KHR_get_memory_requirements2andVK_KHR_get_physical_device_properties2
From what I checked, wgpu does not require all of those extensions so the only way we could use multi-planar textures would be if we had at least vulkan 1.1 and I think wgpu ensures that (unless I read the code wrong)
| let (width, height) = match (self.format, plane) { | ||
| (TextureFormat::NV12 | TextureFormat::P010, Some(0)) => (width, height), | ||
| (TextureFormat::NV12 | TextureFormat::P010, Some(1)) => (width / 2, height / 2), | ||
| _ => (width, height), | ||
| }; |
There was a problem hiding this comment.
My only worry here is that when we add future multi-planar formats, there will be no error to tell us to populate this. Maybe a (debug) assert in the catchall branch to assert that the format is single-planar and maybe a test which calls this function on all texture formats?
There was a problem hiding this comment.
I added the test but I'm not sure if I put it in the right file. I wanted to reuse TEXTURE_FORMAT_LIST from wgpu-info but it's not available from wgpu-types so the test is in wgpu-info which seems wrong to me
noituri
force-pushed
the
@noituri/renderable-nv12-texture
branch
from
5a10d31 to
a87815a
Compare
noituri
force-pushed
the
@noituri/renderable-nv12-texture
branch
from
a87815a to
201c251
Compare
2 participants
Connections
Closes #8205
Description
Currently it was not possible to render onto planes of multiplanar textures (in this case, it's only possible for NV12).
To make it work:
render_extentis calculated for texture viewsTesting
I tried to render on both Vulkan and DX12 (the only supported backends) + I've added tests.
987 tests run: 982 passed, 5 failed, 12 skipped.On my machine 5 tests were failing before and after my changes.
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.