Skip to content

Conversation

@ggerganov
Copy link
Member

@ggerganov ggerganov commented May 26, 2025

Some changes like #13706 (comment) have more pronounced performance effects when running in Debug build. This PR adds an option to do that:

CMAKE_OPTS="-DCMAKE_BUILD_TYPE=Debug" ./scripts/compare-commits.sh ...

@github-actions github-actions bot added the script Script related label May 26, 2025
@slaren
Copy link
Member

slaren commented May 26, 2025

I have been setting cmake_opts directly via an env variable when I need to run compare-commits.sh with different build settings. It could be capitalized and made the standard way to do this.

@ggerganov ggerganov merged commit a26c4cc into master May 26, 2025
2 checks passed
@ggerganov ggerganov deleted the gg/scripts-add-debug-option branch May 26, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

script Script related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants