-
Notifications
You must be signed in to change notification settings - Fork 13.3k
ggml: WebGPU backend host improvements and style fixing #14978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like one test is failing, I'll investigate that. |
This comment was marked as spam.
This comment was marked as spam.
A couple updates:
Going forward, I'll roll my own releases of Dawn when necessary, and once the Dawn folks are able to get their CI working again. Otherwise the code here is ready for review/merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going forward, I'll roll my own releases of Dawn when necessary, and once the Dawn folks are able to get their CI working again.
Sounds good 👍
@reeselevine It looks like the CI is stalling after a crash due to missing SET_ROWS support. |
@CISC yeah I noticed that after it was merged 😞. Simplest solution is to disable set rows for now, I have a commit ready: reeselevine@ae8edbf But I also am working on adding support for SET_ROWS. If I get that done today I'll open a PR with support for it, otherwise I'll open a quick PR with that fix. |
This PR adds a few improvements to the host-side setup for WebGPU, which should make it easier to add more operations/improve performance: