Chatapi ignore empty sampling #16330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allozaur
approved these changes
Sep 29, 2025
|
Close #16201 |
|
@ServeurpersoCom can u please update the static build to solve the conflict? |
ServeurpersoCom
force-pushed
the
chatapi-ignore-empty-sampling
branch
from
c167978 to
3f6aa5d
Compare
yael-works
pushed a commit
to yael-works/llama.cpp
that referenced
this pull request
Oct 15, 2025
* fix: skip empty sampling fields instead of coercing to 0 in chat API options * chore: update webui build output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #16201
Added a reusable guard when building chat API options so empty sampling fields are excluded instead of coerced to zero in outgoing requests.