Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Metal backend support for
POOL_1D
operators.Until now, only the
POOL_2D
was implemented for Metal.With this change, models relying on 1D pooling can now run fully accelerated on Apple GPUs through Metal in an analog way.
Implementation Details
Added new Metal compute kernels in
ggml-metal.metal
:kernel_pool_1d_max_f32
kernel_pool_1d_avg_f32
Implemented
ggml_metal_op_pool_1d
analogous toggml_metal_op_pool_2d
, including:ggml_metal_kargs_pool_1d
)x