Skip to content

Conversation

@rhjdvsgsgks
Copy link
Contributor

No description provided.

@cebtenzzre
Copy link
Collaborator

This was going to be included in #2840 but the user deleted their account so it never got merged.

@rhjdvsgsgks
Copy link
Contributor Author

rhjdvsgsgks commented Nov 4, 2023

i just looked his/her changes and found some issue:

  1. ocl-icd is not needed to installed explicitly. because it required by clblast as a dependency. and they also mentioned the "LD_LIBRARY_PATH" trick. which will use libopencl.so from path without looking from ocl icd. so, ocl-icd seems unnecessary at here
  2. their pr missed pkg-config . which is important to linking cl during the build process

@staviq
Copy link
Contributor

staviq commented Nov 4, 2023

While we're at termux instructions

Current instructions specify apt as package manager, and for reasons unclear, that doesn't always work, however pkg with the same parameters does work.

Since I cannot pinpoint a reason, replacing apt with pkg would be too much of a guess, so instead it could be helpful to simply mention pkg as alternative to apt in case of problems.

@cebtenzzre
Copy link
Collaborator

Current instructions specify apt as package manager, and for reasons unclear, that doesn't always work, however pkg with the same parameters does work.

apt should work as long as you have a mirror selected (via termux-change-repo) and have run apt update at some point. pkg is a wrapper that automatically does these things, which makes it slower but may be a good idea to use in the README.

@rhjdvsgsgks
Copy link
Contributor Author

i prefer apt install over pkg install. because it just do what it said (install) rather than do something unexpected (update and then install)

@ggerganov
Copy link
Member

Not sure if this is relevant any more - reopen if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants