server: multimodal - fix misreported prompt and num prompt tokens #5896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address #5852, #5863
The issue is all normal token processing is skipped for multimodal so it outputs no tokens processed in the response. This is wrong.
To fix, we set the number of tokens processed to it's correct value in
ingest_images
where the prompt is tokenized for multimodal.Additionally a fix for the prompt being set to the empty string for multimodal responses. Basically we iteratively rebuild the initial prompt since it was cleared.
I think it would be best to unify the token processing between multimodal and regular, but this PR does not aim to address that.