Skip to content

Conversation

@ngxson
Copy link
Collaborator

@ngxson ngxson commented Sep 2, 2024

Some steps in server test script are missing timeout config, which make it to use the default value of 300 seconds

This causes the the CI to randomly (and rarely) fail. Mostly due to the instability of hosted runner:

This PR add timeout everywhere in the script, the value is 600 seconds, which is double the default value.


@github-actions github-actions bot added examples python python script changes server labels Sep 2, 2024
@ngxson
Copy link
Collaborator Author

ngxson commented Sep 2, 2024

Small note: I tested the stability of CI by re-running test multiple times (mixed between slow and default test configs).

In rare occasion, windows test failed due to ERROR: Server stopped listening. After more careful inspections, I believe that the problem comes from race condition inside the test script itself. Since it rarely happens and is windows-only, I won't go deeper right now (i.e. won't fix)

@ngxson ngxson merged commit 48baa61 into ggml-org:master Sep 2, 2024
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
Nexesenex pushed a commit to Nexesenex/croco.cpp that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples python python script changes server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants