Skip to content

Conversation

etra0
Copy link

@etra0 etra0 commented Nov 3, 2023

If we have a null path, we then do a last check in bin/ggml-metal because that's where the metal file is located in the case of cmake builds.

Fixes #1419.

If we have a null path, we then do a last check in `bin/ggml-metal` because
that's where the metal file is located in the case of cmake builds.
@codesoda
Copy link
Contributor

codesoda commented Nov 3, 2023

@etra0 Have you also had issues with #1397 / #1415 and being unable to find ggml-metal.metal on disk in release builds?

@ggerganov
Copy link
Member

Yup, the proper fix would be #1415
Hardcoding "bin/..." is a hack on top of an existing hack. With the env variable it should be a bit more generic

@ggerganov ggerganov closed this Nov 3, 2023
@etra0
Copy link
Author

etra0 commented Nov 3, 2023

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake on macOS M2: The file name is invalid

3 participants