fix: avoid double gzip compression in response middleware #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent double gzip compression when upstream response is already gzip-compressed or has a different Content-Encoding - Remove gzip headers and pass through unmodified when encountering existing compression - Add two tests verifying that middleware does not perform double compression with gzip-encoded responses and Prometheus metrics - Ensure decompression works correctly and responses are not gzip-encoded twice fix #47 Signed-off-by: appleboy <[email protected]>
- Split long assertion and error message lines for improved readability in tests - Replace hardcoded "gzip" string with the gzipEncoding variable for consistency in tests - Remove trailing blank line from handler.go Signed-off-by: appleboy <[email protected]>
- Move the gzip encoding value to gzip.go and use the constant instead of a hardcoded string - Remove the redundant gzipEncoding constant from handler_test.go Signed-off-by: appleboy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #47