timeout: fix data races via copied context; abort main context post finish/timeout; restore fast-path BufferPool; tests pass with -race #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inish/timeout; restore fast-path BufferPool; tests pass with -race
Author
|
it is passing all the tests, except Bearer PR Check for using unsafe. |
…anicking Reason: re-panicking in non-debug mode depended on Gin's recovery defer still being in scope. Under certain timings (goroutine scheduling, recovery frame unwinding), the re-panic escaped recovery and intermittently failed tests (e.g., TestTimeoutPanic with high -count). We now always handle the panic inside the timeout middleware by writing a 500 with 'panic caught: <value>' and only include the stack trace when gin.IsDebugging(). This removes timing-dependent behavior, avoids double-recovery, and keeps the rest of the middleware semantics intact (chain continues on copied context, main goroutine flushes/aborts). Result: deterministic behavior and passing tests under -race and high iteration counts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I’ll be honest — I used AI to create this PR.
I’m still trying to understand what’s happening, but this PR might help with root causing or solving #45, and it might also fix my issue #81.