Skip to content

windows-ui: fix inverted user interactive check #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2020
Merged

windows-ui: fix inverted user interactive check #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/shared/Microsoft.Git.CredentialManager/Interop/Windows/WindowsSessionManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public unsafe bool IsDesktopSession
// In .NET 5 the implementation on Windows has been 'fixed', but still POSIX versions always return true.
//
// This code is lifted from the .NET 5 targeting dotnet/runtime implementation for Windows:
// https://github.com/dotnet/runtime/blob/8c10a98c13263eea806d4fcecb76d29e38593539/src/libraries/System.Private.CoreLib/src/System/Environment.Windows.cs#L125-L145
// https://github.com/dotnet/runtime/blob/cf654f08fb0078a96a4e414a0d2eab5e6c069387/src/libraries/System.Private.CoreLib/src/System/Environment.Windows.cs#L125-L145

// Per documentation of GetProcessWindowStation, this handle should not be closed
IntPtr handle = User32.GetProcessWindowStation();
Expand All @@ -31,7 +31,7 @@ public unsafe bool IsDesktopSession
if (User32.GetUserObjectInformation(handle, User32.UOI_FLAGS, &flags,
(uint) sizeof(USEROBJECTFLAGS), ref dummy))
{
return (flags.dwFlags & User32.WSF_VISIBLE) == 0;
return (flags.dwFlags & User32.WSF_VISIBLE) != 0;
}
}

Expand Down