Improve ARM64 support of the sdk function
#456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisameling
approved these changes
Dec 22, 2022
Contributor
dennisameling
left a comment
dennisameling
left a comment
There was a problem hiding this comment.
LGTM - left one minor comment. Thanks!
This is needed so that e.g. `sdk cd <package>` won't mistake `git-sdk-arm64` for `git-sdk-64`. Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
We cannot trust `uname -m` too much when building on ARM64, as there is no Windows/ARM64 version of the MSYS2 runtime (due to lack of Cygwin support for that platform). Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
This was referenced Jan 19, 2023
Member
Author
|
/deploy mingw-w64-git-extra The i686/x86_64 and the arm64 workflow runs were started. |
Member
Author
|
/deploy git-extra The i686/x86_64 and the arm64 workflow runs were started. |
Member
Author
That didn't work because the directory is still named
That worked! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Git for Windows' SDK, we prominently advertise the
sdkfunction, but it does not quite Do The Right Thing ingit-sdk-arm64yet. This PR addresses that.