please.sh: drop a lot of functionality that is no longer used #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisameling
approved these changes
Dec 22, 2022
Contributor
dennisameling
left a comment
dennisameling
left a comment
There was a problem hiding this comment.
This is super helpful for my follow-up work to prevent me from updating things that are no longer used. Thank you!
dscho
force-pushed
the
drop-obsolete-parts-from-please.sh
branch
2 times, most recently
from
7235016 to
fb6061a
Compare
Member
Author
|
@dennisameling FYI I added a commit intended to trigger the |
Member
Author
|
I also kicked off a full |
Member
Author
|
The big honking "run one script to do it all" approach was abandoned bit by bit with the move to automation and parallel builds. Most of these functions have not been used in several years, so let's get rid of them. Signed-off-by: Johannes Schindelin <[email protected]>
We just removed a ton of functionality from that file, and expect none of it to be used, still. Let's make sure, at least by building the sdk artifacts (and the installer) that this is the case. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
drop-obsolete-parts-from-please.sh
branch
from
fb6061a to
3a7b10d
Compare
Member
Author
|
I'll merge it when I'm back. |
This was referenced Dec 27, 2022
Member
Author
|
It is time to merge this, I think. |
dscho
added a commit
to dscho/build-extra
that referenced
this pull request
Feb 27, 2023
…-note When generating the release notes of v2.40.0-rc0, I noticed in git-for-windows/git#4316 (comment) that a section was added unnecessarily. The reason is that a crucial function was removed in git-for-windows#457. The plan was to retire the entire release process based on `please.sh` and Azure Pipelines, and redo everything in git-for-windows-automation via a `tag-git` workflow, but that workflow simply is not ready yet. In preparation for those improved workflows, I already reimplemented the `sed` logic of `please.sh mention [...]` with a more straight-forward node.js script. Let's just use that script in `please.sh mention` before phasing out the functionality from `please.sh`. Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to a comment that asked whether
releaseis still in use.