github-release: prepare for immutable releases #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a new initiative to increase confidence in GitHub Releases: https://github.blog/changelog/2025-10-28-immutable-releases-are-now-generally-available/ The official guidance is to create a draft release, then attach all assets, then publish: https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/immutable-releases#best-practices-for-publishing-immutable-releases We _almost_ do that already. The only exception is the additional update to create a discussion for each new release. This was separated out earlier in response to a missing permission of the GitHub App used to perform the job, but is likely incompatible with immutable releases. So let's revert b59f512 (github-release: create the Discussion separately, 2024-09-18). Signed-off-by: Johannes Schindelin <[email protected]>
mjcheetham
approved these changes
Nov 4, 2025
|
I guess I should have done this before releasing Git for Windows v2.52.0-rc0 ;-) 
At least -rc1 will now exercise this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new initiative to increase confidence in GitHub Releases. The official guidance is to create a draft release, then attach all assets, then publish.
We almost do that already. The only exception is the additional update to create a discussion for each new release. This was separated out earlier in response to a missing permission of the GitHub App used to perform the job, but is likely incompatible with immutable releases. So let's revert b59f512 (github-release: create the Discussion separately, 2024-09-18).