Skip to content

Conversation

@ldennington
Copy link

b980ccf added libmpc-3.dll to mingw32/bin, but this dependency is never used. Removing accordingly.

b980ccf added libmpc-3.dll to mingw32/bin, but this dependency is never
used. Removing accordingly.
@ldennington ldennington self-assigned this Dec 29, 2022
@rimrul
Copy link
Member

rimrul commented Dec 30, 2022

I'm not sure that is a good idea. We'll probably need to update to rebuild the packages depending on libmpc instead. See msys2/MINGW-packages@5adf565

Edit: looks like gcc is the only package we care about that depends on libmpc.

That should be updated since f0c95e9.

How (and on which commit) did you check it was unused? And why did that check only turn up the 32bit version?

@rimrul
Copy link
Member

rimrul commented Dec 30, 2022

How (and on which commit) did you check it was unused? And why did that check only turn up the 32bit version?

I think I puzzled it together. You probably missed the failed 64bit check run on
git-for-windows/build-extra#462

I reran the failed jobs, they're not complaining anymore. libpmc is not unused anymore.

@ldennington
Copy link
Author

I reran the failed jobs, they're not complaining anymore. libpmc is not unused anymore.

Ok, great. I'll go ahead and close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants