Skip to content

Conversation

@dennisameling
Copy link
Collaborator

@dennisameling dennisameling commented Feb 4, 2023

This prepares the git-sdk-arm64 for being able to build SDK artifacts.

I built the artifacts locally through e.g. /usr/src/build-extra/please.sh create-sdk-artifact --architecture=aarch64 --out=/sdk-build-installers build-installers:

  • build-installers ✅ (784MB)
  • makepkg-git ✅ (602MB)
  • minimal ✅ (415MB)

I used build-installers to build Git as follows: /usr/src/build-extra/please.sh build-mingw-w64-git --only-aarch64 -o artifacts HEAD. That completed successfully 🎉

Comment on lines +60 to +64
/clangarm64/lib/python*/
!/clangarm64/lib/python*/site-packages/
!/clangarm64/lib/python*/test/
/clangarm64/lib/python*/site-packages/asciidoc/
/clangarm64/lib/python*/site-packages/asciidoc*-info/
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to be more mindful here by including only specific folders from /clangarm64/lib/python, but the amount of folders became so large that I just chose to include the entire folder instead and exclude the largest unnecessary ones. With this config, the entire /clangarm64/lib/python3.10 folder is ~26MB, so I think that's ok.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. An alternative might be to use asciidoctor instead, which uses Ruby, like we use to build mingw-w64-x86_64-git-doc-html...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to, but asciidoctor isn't available yet for clang-aarch64 😅

Comment on lines +15 to +30
# Clang and friends
/clangarm64/bin/ar.exe
/clangarm64/bin/as.exe
/clangarm64/bin/cc.exe
/clangarm64/bin/clang.exe
/clangarm64/bin/ld.exe
/clangarm64/bin/libgmp-*[0-9].dll
/clangarm64/bin/libclang.dll
/clangarm64/bin/libclang-cpp.dll
/clangarm64/bin/libLLVM-*[0-9].dll
/clangarm64/bin/libwinpthread-*[0-9].dll
/clangarm64/bin/libzstd.dll
/clangarm64/bin/llvm-strip.exe
/clangarm64/bin/windres.exe
/clangarm64/lib/clang/*/include/
/clangarm64/lib/clang/*/lib/
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is all of this really needed in the minimal SDK? libLLVM-15.dll alone is ~96MB already...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear that's the price of using a low-level virtual machine ;-)

@dennisameling dennisameling requested a review from dscho February 4, 2023 16:28
@dennisameling dennisameling merged commit 3a9c5e5 into main Feb 4, 2023
@dennisameling dennisameling deleted the update-sparse branch February 4, 2023 16:56
dscho added a commit that referenced this pull request Aug 12, 2024
In #6, we switched
the `makepkg-git` SDK artifact in git-sdk-arm64 away from using
AsciiDoctor to using AsciiDoc instead. The reason was that the former
was not yet supported in the `clangarm64` packages in MSYS2.

In the meantime, AsciiDoctor is not only supported, but now also
required to build `mingw-w64-clang-aarch64-git`.

So let's adjust the `makepkg-git` sparse checkout definition
accordingly.

Signed-off-by: Johannes Schindelin <[email protected]>
dscho added a commit that referenced this pull request Aug 13, 2024
In #6, we switched
the `makepkg-git` SDK artifact in git-sdk-arm64 away from using
AsciiDoctor to using AsciiDoc instead. The reason was that the former
was not yet supported in the `clangarm64` packages in MSYS2.

In the meantime, AsciiDoctor is not only supported, but now also
required to build `mingw-w64-clang-aarch64-git`.

So let's adjust the `makepkg-git` sparse checkout definition
accordingly.

Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants