Skip to content

fscache: add fscache hit statistics #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2018
Merged

fscache: add fscache hit statistics #1910

merged 1 commit into from
Nov 16, 2018

Conversation

benpeart
Copy link

@benpeart benpeart commented Nov 1, 2018

Track fscache hits and misses for lstat and opendir requests. Reporting of statistics is done when the cache is disabled for the last time and freed and is only reported if GIT_TRACE_FSCACHE is set.

Sample output is:

11:33:11.836428 compat/win32/fscache.c:433 fscache: lstat 3775, opendir 263, total requests/misses 4052/269

Signed-off-by: Ben Peart [email protected]

dscho
dscho requested changes Nov 5, 2018
View reviewed changes
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. With that one change to limit those new variables' scope, I think we're good to go!

@benpeart
fscache: add fscache hit statistics
052813a 
Track fscache hits and misses for lstat and opendir requests.  Reporting of
statistics is done when the cache is disabled for the last time and freed
and is only reported if GIT_TRACE_FSCACHE is set.

Sample output is:

11:33:11.836428 compat/win32/fscache.c:433 fscache: lstat 3775, opendir 263, total requests/misses 4052/269

Signed-off-by: Ben Peart <[email protected]>
@weekly-digest weekly-digest bot mentioned this pull request Nov 11, 2018
Closed
@dscho dscho merged commit 8d05b91 into git-for-windows:master Nov 16, 2018
@dscho
Copy link
Member

dscho commented Nov 16, 2018

Thank you!

@dscho dscho added this to the v2.19.1(2) milestone Nov 16, 2018
@weekly-digest weekly-digest bot mentioned this pull request Nov 18, 2018
Closed
dscho added a commit to dscho/git that referenced this pull request Nov 19, 2018
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
438314b 
…ics-gfw

fscache: add fscache hit statistics
dscho added a commit to dscho/git that referenced this pull request Nov 20, 2018
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
ea1df4e 
…ics-gfw

fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Nov 21, 2018
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
c2e8fb3 
fscache: add fscache hit statistics
dscho added a commit to dscho/git that referenced this pull request Nov 23, 2018
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
814d563 
…ics-gfw

fscache: add fscache hit statistics
@weekly-digest weekly-digest bot mentioned this pull request Nov 25, 2018
Closed
dscho added a commit to dscho/git that referenced this pull request Nov 30, 2018
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
c93ed5e 
…ics-gfw

fscache: add fscache hit statistics
dscho added a commit to dscho/git that referenced this pull request Dec 1, 2018
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
17a920d 
…ics-gfw

fscache: add fscache hit statistics
dscho added a commit to dscho/git that referenced this pull request Dec 9, 2018
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
a7a949e 
…ics-gfw

fscache: add fscache hit statistics
dscho added a commit to dscho/git that referenced this pull request Dec 15, 2018
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
80a78c5 
…ics-gfw

fscache: add fscache hit statistics
dscho added a commit to dscho/git that referenced this pull request Feb 7, 2019
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
9370b56 
…ics-gfw

fscache: add fscache hit statistics
dscho added a commit to dscho/git that referenced this pull request Feb 7, 2019
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
d9f8dcf 
…ics-gfw

fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Jan 6, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
be4cb30 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Jan 7, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
7cad3d6 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Jan 7, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
fafcb7d 
fscache: add fscache hit statistics
@dscho dscho mentioned this pull request Jan 7, 2025
Merged
dscho added a commit to dscho/git that referenced this pull request Jan 7, 2025
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
c6334a1 
…ics-gfw

fscache: add fscache hit statistics
dscho added a commit to dscho/git that referenced this pull request Jan 7, 2025
@dscho
Merge pull request git-for-windows#1910 from benpeart/fscache_statist…
54a8998 
…ics-gfw

fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Jan 7, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
9318adc 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Jan 7, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
4160af8 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Jan 8, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
b6b2349 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Jan 8, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
efa094f 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Jan 8, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
ef54ca8 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Jan 8, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
0942147 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Jan 9, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
2e47c99 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Jan 9, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
60e2d3a 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Jan 17, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
7330a64 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Jan 27, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
d8917e9 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Jan 27, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
5ab82e3 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Jan 27, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
f4556e3 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Jan 27, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
cf039e9 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Jan 27, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
61adc5d 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Jan 28, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
6bea2d1 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Jan 28, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
a61945f 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Feb 3, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
6047a40 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Feb 5, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
320b8c6 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Feb 5, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
272150b 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Feb 5, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
1fe8a10 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Feb 5, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
ab3abf5 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Feb 6, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
b86bca6 
fscache: add fscache hit statistics
dscho added a commit that referenced this pull request Feb 6, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
1b7c1ff 
fscache: add fscache hit statistics
git-for-windows-ci pushed a commit that referenced this pull request Feb 6, 2025
@dscho
Merge pull request #1910 from benpeart/fscache_statistics-gfw
1aaf76b 
fscache: add fscache hit statistics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dscho dscho dscho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.19.2

Development

Successfully merging this pull request may close these issues.

2 participants

@benpeart @dscho