Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs #2351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vcpkg_install batch file depends on the availability of a working Git on the CMD path. This may not be present if the user has selected the 'bash only' option during Git-for-Windows install. Detect and tell the user about their lack of a working Git in the CMD window. Fixes git-for-windows#2348. A separate PR git-for-windows/build-extra#258 now highlights the recommended path setting during install. Signed-off-by: Philip Oakley <[email protected]>
dscho
reviewed
Oct 6, 2019
dscho
reviewed
Oct 6, 2019
The vcpkg downloads may not succeed. Warn careful readers of the time out. A simple retry will usually resolve the issue. Signed-off-by: Philip Oakley <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 7, 2019
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 7, 2019
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 7, 2019
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 7, 2019
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
1 task
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 9, 2019
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 9, 2019
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 9, 2019
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 11, 2019
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
dscho
added a commit
that referenced
this pull request
Oct 11, 2019
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
dscho
added a commit
that referenced
this pull request
Oct 11, 2019
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
dscho
added a commit
that referenced
this pull request
Oct 12, 2019
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 15, 2019
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 15, 2019
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
dscho
added a commit
that referenced
this pull request
Oct 15, 2019
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
dscho
added a commit
that referenced
this pull request
Sep 29, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 30, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 30, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 2, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 2, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
dscho
added a commit
that referenced
this pull request
Oct 2, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 3, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 3, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 5, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 5, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 5, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 6, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 6, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 6, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
dscho
added a commit
that referenced
this pull request
Oct 7, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
dscho
added a commit
that referenced
this pull request
Oct 7, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 7, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 7, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 7, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 8, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 8, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 8, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 8, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 8, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 8, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 8, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 10, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 10, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 10, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 10, 2025
Vcpkg Install: detect lack of working Git, and note possible vcpkg time outs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing out the vs/master branch that should provide a ready-to-go git.sln for compilation with
Visual Studio, I hit a couple of snags.
These ultimately were problems with my local installation, but the sln compilation should offer extra guidance if users fall into the same trap.
The compilation stage that uses the vcpkg download can also fail on slow networks, so a batch file remark is included to inform users who follow-up the error message.
The fixes #2349 (in conjunction with git-for-windows/build-extra#258).
Signed-off-by: Philip Oakley [email protected]