config: normalize the path of the system gitconfig #2370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git for Windows is compiled with a runtime prefix, and that runtime prefix is typically `C:/Program Files/Git/mingw64`. As we want the system gitconfig to live in the sibling directory `etc`, we define the relative path as `../etc/gitconfig`. However, as reported by Philip Oakley, the output of `git config --show-origin --system -l` looks rather ugly, as it shows the path as `file:C:/Program Files/Git/mingw64/../etc/gitconfig`, i.e. with the `mingw64/../` part. By normalizing the path, we get a prettier path. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
prettify-etc-gitconfig-path
branch
from
af0d658 to
3a5522c
Compare
dscho
added a commit
that referenced
this pull request
Oct 25, 2019
config: normalize the path of the system gitconfig
dscho
added a commit
that referenced
this pull request
Oct 25, 2019
config: normalize the path of the system gitconfig
dscho
added a commit
that referenced
this pull request
Oct 25, 2019
config: normalize the path of the system gitconfig
dscho
added a commit
that referenced
this pull request
Oct 25, 2019
config: normalize the path of the system gitconfig
|
The on-list change and comments looked good. |
No, indeed, it did not make it into -rc1. |
|
On 25/10/2019 22:04, Johannes Schindelin wrote:
I don't think it got to rc1
No, indeed, it did not make it into -rc1.
Thanks. I'd been on other priorities. I'd only managed the quick
download of rc1 and `git config -l -show-origin`...
|
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 28, 2019
config: normalize the path of the system gitconfig
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 28, 2019
config: normalize the path of the system gitconfig
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 29, 2019
config: normalize the path of the system gitconfig
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 30, 2019
config: normalize the path of the system gitconfig
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 30, 2019
config: normalize the path of the system gitconfig
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 30, 2019
config: normalize the path of the system gitconfig
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the output of
git config --show-originprettier.