Avoid a buffer overrun in needs_hiding()
#2371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this function is passed a path with a trailing slash, it runs right over the end of that path. Let's fix this. Co-authored-by: Alexandr Miloslavskiy <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
fix-needs-hiding-buffer-overrun
branch
from
52301de to
0b6a19e
Compare
dscho
added a commit
that referenced
this pull request
Oct 25, 2019
Avoid a buffer overrun in `needs_hiding()`
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Oct 25, 2019
A buffer overrun in the code to determine which files need to be marked as hidden [was plugged](git-for-windows/git#2371). Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
Oct 25, 2019
Avoid a buffer overrun in `needs_hiding()`
dscho
added a commit
that referenced
this pull request
Oct 25, 2019
Avoid a buffer overrun in `needs_hiding()`
dscho
added a commit
that referenced
this pull request
Oct 25, 2019
Avoid a buffer overrun in `needs_hiding()`
dscho
added a commit
that referenced
this pull request
Oct 30, 2019
Avoid a buffer overrun in `needs_hiding()`
dscho
added a commit
that referenced
this pull request
Nov 2, 2019
Avoid a buffer overrun in `needs_hiding()`
Merged
dscho
added a commit
that referenced
this pull request
Nov 6, 2019
Avoid a buffer overrun in `needs_hiding()`
dscho
added a commit
that referenced
this pull request
Nov 16, 2019
Avoid a buffer overrun in `needs_hiding()`
dscho
added a commit
that referenced
this pull request
Nov 25, 2019
Avoid a buffer overrun in `needs_hiding()`
dscho
added a commit
that referenced
this pull request
Nov 26, 2019
Avoid a buffer overrun in `needs_hiding()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by gitgitgadget#414, this is a minimal fix for the issue that
needs_hiding()runs right outside the buffer when being passed a path with a trailing slash.The patch in gitgitgadget#414 does too many things: it not only fixes the bug, but rewrites a large part of the function. This late in the -rc phase leading up to v2.24.0, I am not willing to risk such a rewrite.
Cc: @SyntevoAlex